Attempted fix for build issues on Linux with RubyGems 2.0.0

On Linux the build is failing with:

  make install
  /usr/bin/install -c -m 0755 wikitext.so /data/shared/bundle/ruby/2.0.0/gems/wikitext-4.0/ext
  /usr/bin/install: `wikitext.so' and `/data/shared/bundle/ruby/2.0.0/gems/wikitext-4.0/ext/wikitext.so' are the same file

Looks to affect many gems with native components:

  https://github.com/rubygems/rubygems/issues/411
  https://bugs.ruby-lang.org/issues/7344
  https://bugs.ruby-lang.org/issues/7698

The workaround applied here is to move the extension files down one
level in the hierarchy.

Signed-off-by: Wincent Colaiuta <win@wincent.com>

diff --git a/Rakefile b/Rakefile
index cbae4f8b71433641bab862a05667cb3ca0b1e343..22e52f684391da54a5d932000a4a5d84c5d8cb8a 100644 (file)
--- a/Rakefile
+++ b/Rakefile
@@ -29,52 +29,52 @@ $LOAD_PATH.unshift(File.expand_path(File.join(File.dirname(__FILE__), 'lib')))
 require 'wikitext/version'
 
 CLEAN.include   Rake::FileList['**/*.so', '**/*.bundle', '**/*.o', '**/mkmf.log', '**/Makefile']
-CLOBBER.include Rake::FileList['ext/wikitext_ragel.c']
+CLOBBER.include Rake::FileList['ext/wikitext/wikitext_ragel.c']
 
 task :default => :all
 
 desc 'Build all and run all specs'
 task :all => [:make, :spec]
 
-extension_makefile  = 'ext/Makefile'
-ragel               = 'ext/wikitext_ragel.c'
-built_extension     = "ext/wikitext.#{RbConfig::CONFIG['DLEXT']}" # wikitext.bundle (Darwin), wikitext.so (Linux)
+extension_makefile  = 'ext/wikitext/Makefile'
+ragel               = 'ext/wikitext/wikitext_ragel.c'
+built_extension     = "ext/wikitext/wikitext.#{RbConfig::CONFIG['DLEXT']}" # wikitext.bundle (Darwin), wikitext.so (Linux)
 extension_files     = FileList[
-  'ext/Makefile',
-  'ext/ary.c',
-  'ext/ary.h',
-  'ext/parser.c',
-  'ext/parser.h',
-  'ext/ruby_compat.h',
-  'ext/str.c',
-  'ext/str.h',
-  'ext/token.c',
-  'ext/token.h',
-  'ext/wikitext.c',
-  'ext/wikitext.h',
-  'ext/wikitext_ragel.c',
-  'ext/wikitext_ragel.h',
+  'ext/wikitext/Makefile',
+  'ext/wikitext/ary.c',
+  'ext/wikitext/ary.h',
+  'ext/wikitext/parser.c',
+  'ext/wikitext/parser.h',
+  'ext/wikitext/ruby_compat.h',
+  'ext/wikitext/str.c',
+  'ext/wikitext/str.h',
+  'ext/wikitext/token.c',
+  'ext/wikitext/token.h',
+  'ext/wikitext/wikitext.c',
+  'ext/wikitext/wikitext.h',
+  'ext/wikitext/wikitext_ragel.c',
+  'ext/wikitext/wikitext_ragel.h',
 ]
 
 desc 'Build C extension'
 task :make => [ragel, extension_makefile, built_extension]
 
-file ragel => ['ext/wikitext_ragel.rl'] do
-  Dir.chdir('ext') do
+file ragel => ['ext/wikitext/wikitext_ragel.rl'] do
+  Dir.chdir('ext/wikitext') do
     # pass the -s switch here because otherwise Ragel is totally silent
     # I like to have visual confirmation that it's actually run
     sh 'ragel -G2 -s wikitext_ragel.rl'
   end
 end
 
-file extension_makefile => ['ext/extconf.rb', 'ext/depend', ragel] do
-  Dir.chdir('ext') do
+file extension_makefile => ['ext/wikitext/extconf.rb', 'ext/wikitext/depend', ragel] do
+  Dir.chdir('ext/wikitext') do
     ruby 'extconf.rb'
   end
 end
 
 file built_extension => extension_files do
-  Dir.chdir('ext') do
+  Dir.chdir('ext/wikitext') do
     sh 'make && touch .built'
   end
 end

diff --git a/ext/.autotest b/ext/wikitext/.autotest
similarity index 100%
rename from ext/.autotest
rename to ext/wikitext/.autotest

diff --git a/ext/.gitignore b/ext/wikitext/.gitignore
similarity index 70%
rename from ext/.gitignore
rename to ext/wikitext/.gitignore
index 7589ca029e7b1b3e4f3562ed41d04586a689e66d..dd0c1bacd68cdfed7131f83832f84d7b5ffdad23 100644 (file)
--- a/ext/.gitignore
+++ b/ext/wikitext/.gitignore
@@ -2,6 +2,6 @@
 *.bundle
 *.so
 .built
+.RUBYARCHDIR.time
 Makefile
 mkmf.log
-

diff --git a/ext/ary.c b/ext/wikitext/ary.c
similarity index 100%
rename from ext/ary.c
rename to ext/wikitext/ary.c

diff --git a/ext/ary.h b/ext/wikitext/ary.h
similarity index 100%
rename from ext/ary.h
rename to ext/wikitext/ary.h

diff --git a/ext/depend b/ext/wikitext/depend
similarity index 100%
rename from ext/depend
rename to ext/wikitext/depend

diff --git a/ext/extconf.rb b/ext/wikitext/extconf.rb
similarity index 100%
rename from ext/extconf.rb
rename to ext/wikitext/extconf.rb

diff --git a/ext/parser.c b/ext/wikitext/parser.c
similarity index 100%
rename from ext/parser.c
rename to ext/wikitext/parser.c

diff --git a/ext/parser.h b/ext/wikitext/parser.h
similarity index 100%
rename from ext/parser.h
rename to ext/wikitext/parser.h

diff --git a/ext/ruby_compat.h b/ext/wikitext/ruby_compat.h
similarity index 100%
rename from ext/ruby_compat.h
rename to ext/wikitext/ruby_compat.h

diff --git a/ext/str.c b/ext/wikitext/str.c
similarity index 100%
rename from ext/str.c
rename to ext/wikitext/str.c

diff --git a/ext/str.h b/ext/wikitext/str.h
similarity index 100%
rename from ext/str.h
rename to ext/wikitext/str.h

diff --git a/ext/token.c b/ext/wikitext/token.c
similarity index 100%
rename from ext/token.c
rename to ext/wikitext/token.c

diff --git a/ext/token.h b/ext/wikitext/token.h
similarity index 100%
rename from ext/token.h
rename to ext/wikitext/token.h

diff --git a/ext/wikitext.c b/ext/wikitext/wikitext.c
similarity index 100%
rename from ext/wikitext.c
rename to ext/wikitext/wikitext.c

diff --git a/ext/wikitext.dot b/ext/wikitext/wikitext.dot
similarity index 100%
rename from ext/wikitext.dot
rename to ext/wikitext/wikitext.dot

diff --git a/ext/wikitext.h b/ext/wikitext/wikitext.h
similarity index 100%
rename from ext/wikitext.h
rename to ext/wikitext/wikitext.h

diff --git a/ext/wikitext_ragel.c b/ext/wikitext/wikitext_ragel.c
similarity index 100%
rename from ext/wikitext_ragel.c
rename to ext/wikitext/wikitext_ragel.c

diff --git a/ext/wikitext_ragel.h b/ext/wikitext/wikitext_ragel.h
similarity index 100%
rename from ext/wikitext_ragel.h
rename to ext/wikitext/wikitext_ragel.h

diff --git a/ext/wikitext_ragel.rl b/ext/wikitext/wikitext_ragel.rl
similarity index 100%
rename from ext/wikitext_ragel.rl
rename to ext/wikitext/wikitext_ragel.rl

diff --git a/wikitext.gemspec b/wikitext.gemspec
index d0ae941b49eeb625cc09fa1f6bcaab4b5983b8fd..dfc19d0c64e43bad4dfd1c750f7196bfdffd0b9b 100644 (file)
--- a/wikitext.gemspec
+++ b/wikitext.gemspec
@@ -36,7 +36,7 @@ Gem::Specification.new do |s|
   s.required_ruby_version = '>= 2.0.0'
   s.summary               = 'Wikitext-to-HTML translator'
   s.require_paths         = ['ext', 'lib']
-  s.extensions            = ['ext/extconf.rb']
+  s.extensions            = ['ext/wikitext/extconf.rb']
   s.executables           = ['wikitext']
   s.files                 = Dir[
     'bin/wikitext',