]> git.wincent.com - wikitext.git/commit
Create "special links" from external rather than internal links
authorWincent Colaiuta <win@wincent.com>
Sun, 1 Feb 2009 21:03:47 +0000 (22:03 +0100)
committerWincent Colaiuta <win@wincent.com>
Sun, 1 Feb 2009 21:03:47 +0000 (22:03 +0100)
commit7491ebc6c20030bb09e5762c1f8eb0c475244324
treebc9c5d5520fa51a4f0c7d67c4021922deb654ae3
parent8edebc5d363c0d4311fc606e2d72f52248100fa9
Create "special links" from external rather than internal links

It was a clumsy design decision to offer detection of "special links"
inside internal links:

  [[/issues/20 | ticket #20]]

A much nicer syntax is to use external links instead:

  [/issues/20 ticket #20]

In this commit I rip out the old implementation as well as a
supporting instance variable (treat_slash_as_special), and a
couple of related low-level struct members used at the C
level (treat_slash_as_special and special_link) which were
themselves all probably evidence of "design smell".

In place of the old feature we move handling of "path"-style
links to inside of external links. Specs and docs are updated
accordingly.

See also:

  https://rails.wincent.com/issues/1208

Signed-off-by: Wincent Colaiuta <win@wincent.com>
12 files changed:
doc/README
doc/rdoc.rb
ext/parser.c
ext/token.c
ext/token.h
ext/wikitext.c
ext/wikitext_ragel.c
ext/wikitext_ragel.rl
spec/external_link_spec.rb
spec/internal_link_spec.rb
spec/link_encoding_spec.rb
spec/wikitext_spec.rb