From ab92b650b5f18fb53ee9f6229fd82638d069d9af Mon Sep 17 00:00:00 2001 From: Greg Hurrell Date: Fri, 31 Jul 2015 18:54:37 -0700 Subject: [PATCH] Don't mutate input array in joinDigits() `reverse()` is a nasty API. It returns the reversed array, but also mutates it in place. Noticed while using `joinDigits()` to log stuff while developing. --- src/joinDigits.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/joinDigits.js b/src/joinDigits.js index 2230467..3d6eae2 100644 --- a/src/joinDigits.js +++ b/src/joinDigits.js @@ -15,7 +15,9 @@ export default function joinDigits( digits: Array, base: number ): string { - return digits.reverse() + return digits + .slice() + .reverse() .map(number => number.toString(base)) .join(''); } -- 2.37.1