Wincent Colaiuta [Tue, 27 Nov 2007 22:32:57 +0000 (23:32 +0100)]
Fix last of test-time crashes under 10.5
Fix another test-time crash that's new under 10.5, this one stemming from
the use of the Object root class. It appears that this class is not
compatible with the new runtime when GC is set to "required", as these
same tests didn't used to crash prior to turning that setting on.
Wincent Colaiuta [Tue, 27 Nov 2007 22:27:33 +0000 (23:27 +0100)]
Fix test-time crashes caused by 10.5 runtime changes
The Objective-C 2.0 runtime in Leopard expects more methods to be
implemented in root classes than was the case under Tiger.
This commit adds two such methods to the WOLightweightRoot implementation,
doesNotRecognizeSelector: and methodSignatureForSelector:, thus eliminating
a crash that would derail the test run.
The signatureWithObjCTypes: method in NSMethodSignature is at last exposed
in Leopard, so remove the all the support code that was previously used to
(carefully) work with (or around) it and just use the now-official API.
Wincent Colaiuta [Sat, 11 Aug 2007 13:26:18 +0000 (15:26 +0200)]
Code clean-up for garbage collection
I've made a pass through the codebase eliminating message sends that have
effectively been turned into no-ops by the move to garbage collection (retain,
release, autorelease), as well as replacing "release" messages sent to
autorelease pools with "drain", replacing the alloc/init pattern with the
straightforward autoreleased alternative where possible (for brevity),
removing methods that will now never be meaningfully called (dealloc, release,
retainCount etc), and switching some accessors over to synthesized properties
where this enabled me to get rid of no-op retain, release and autorelease
message sends.
I also performed some minor reformatting (better wrapping and column
alignment) where the already-mentioned changes touch code which would benefit
from such reformatting (improved readability); there are still plenty of
places in the codebase where the wrapping could be tweaked to make better use
of the full 132 columns.
Wincent Colaiuta [Sat, 11 Aug 2007 11:42:17 +0000 (13:42 +0200)]
Workaround Objective-C 2.0 properties bug
It turns out that the public-readonly/private-readwrite property pattern is
not broken after all, and a simple workaround is available (redeclare all the
attributes "in whole" rather than "in part" as the documentation suggests).
This commit applies the new workaround and references the Radar and test case
that correspond to the issue.
Wincent Colaiuta [Sat, 11 Aug 2007 11:39:50 +0000 (13:39 +0200)]
Add test case for Objective-C 2.0 properties bug
In a previous commit (f2d45e3) I noted what appears to be a bug in either the
Objective-C 2.0 properties implementation (spurious compiler warnings) or in
its documentation.
I've prepared this test case demonstrating the problem. In the course of doing
so I discovered that the problem has a workaround that is considerably easier
than I originally thought, and the bug doesn't actually make it impossible to
use the public-readonly/private-readwrite property pattern. I will apply the
new workaround in a subsequent commit.
Wincent Colaiuta [Thu, 9 Aug 2007 20:08:23 +0000 (22:08 +0200)]
Use anonymous private categories
"Anonymous" private categories (new in Objective-C 2.0) are a better fit for
private methods because they provide an indication to the compiler of what
methods are expected to be implemented, not just those that "might" be
implemented elsewhere (and available at runtime).
Convert WOTest class to use Objective-C 2.0 properties
This commit converts most of the accessors for the instance variables in the
WOTest class to Objective-C 2.0 properties.
At the same time some unused instance variables were disposed of or marked for
future deprecation.
Note that due to an apparent bug in the compiler I was unable to implement the
public-readonly/private-readwrite pattern as suggested in the documentation,
and so the readonly/readwrite portions are commented out. I will be making a
reduced test case for this and filing a Radar. Watch for a future commit that
adds the Radar number in a comment.
Previouly when growlnotify was not installed env would issue an ugly error
message to the standard error.
This commit redirects standard error to /dev/null so as to suppress this
output and instead checks the exit status of the env tool. When growlnotify
cannot be found in the current PATH a note (not an error or warning) is
printed to the console. Other failure cases issue either an error or a
warning, depending on their severity.
The handling of unrecognized selectors appears to have changed in Leopard in
ways that cause one of the mock object tests to fail. Specifically, an
NSInvalidArgumentException is raised and it appears that the -[NSProxy
doesNotRecognizeSelector:] method is being called; setting breakpoints
indicates that the -forward:: method on the WOMock class is no longer being
invoked.
So I am temporarily gating off this test so that we can get error-free test
runs, pending further investigation. I plan to rework much of the mock/stub
API in any case based on better understanding obtained through my experiences
with RSpec (my use of the terms "mock" and "stub" is incorrect, based on my
first contact with those terms in the OCMock framework); at a minimum, I plan
to rename WOStub and its subclasses to better reflect what it actually does
(it is a message recorder and should probably be called as such). I may also
later add WOMock subclasses that really are stubs (non-verifying mocks).
Remove unit test made redundant by garbage collection
One of the unit tests expected an exception to be raised when working with
objects that don't respond to the retain and release methods, but in a garbage
collected world these messages become no-ops (and in fact I believe that the
compiler literally optimizes them away to nothing).
As such, no exception was being raised and there is no way to "fix" either the
test or the tested implementation: it's simply that the test no longer makes
sense in the context of garbage collection. This commit removes the
now-redundant test.
Found another case in which comparing nil to nil was leading to a failing
test; ultimately the +[NSValue WOTest_compare:] method was being called where
both objects were encoded with type "pointer-to-void".
This commit adds a special case for such comparisons: truly equal pointers are
considered to be NSOrderedSame; all others fall through to the default path
and an exception is raised.
This is a conservative approach because in reality the only kind of pointer
comparison which makes sense in practice is an equality test, not an ordering
test.
Leopard has a bug in the NSGetSizeAndAlignment() function which prevents it
from handling structs which have bitfields in them. This in turn breaks the
+[NSValue valueWithBytes:objCType:] method when used with structs containing
bitfields.
So this commit #ifdefs out the tests which fail as a result of this bug. A
simplified testcase demonstrating the problem has be en added to the "other"
subdirectory. A Radar has been filed (<rdar://problem/5357040>); currently
awaiting on a fix from Apple.
Extensive whitespace cleanup of entire codebase (over 9,300 lines in the diff)
cleaning up mixed tabs and spaces (now uses spaces consistently) and trailing
whitespace at the end of lines.
The behaviour of the @encode directive has changed on Leopard and this breaks
a number of the comparisons that previously worked in Tiger. For example,
comparisons between object pointers and nil, or even between nil and nil,
were broken.
This commit adds some special cases for these types of comparisons which
now perform simple pointer equality tests instead of failing. I also removed
one test which failed on Tiger (when nil was encoded as a numeric scalar) but
no longer fails on Leopard.
Now that this code is stored in a Git repository, remove the build-number embedding
procedure which got the SVK/Subversion revision number and embedded it in each
build.
To avoid possible missunderstandings caused by ambiguous interpretations of
dates (which might appear to be in either US or some kind of European format)
switch to more verbose, explicit dates.
git.wincent.com / WOTest.git / log
